Fixing SODA_SYNC_IVOID so we work with all version 1 SODA services. #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While protocol IVOIDs in the VO give the full version, matching must ignore the the minor version or we'll break when a new minor version is out. Discussion on version 1.1 of SODA is just starting. Let's better clean this up now. Actually, it would even be better if we fixed get_adhocservice_by_ivoid to accept a regular expression, because we we really ought to be matching aginst is ivo://ivoa.net/std/SODA#sync-1\.\d+; but I'd say that can wait until there is thought of SODA 10.x.
|
Backports for PRs like this are really easy, and I expect to do a v1.5.2 out before IVOA, but don't see the exact timeline for 1.6. |
|
CI failures are unrelated and are addressed in separate PRs, so I'll go ahead with this and merge now. Thanks! |
bsipocz
added a commit
that referenced
this pull request
May 22, 2024
Fixing SODA_SYNC_IVOID so we work with all version 1 SODA services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While protocol IVOIDs in the VO give the full version, matching must ignore the the minor version or we'll break when a new minor version is out. Discussion on version 1.1 of SODA is just starting. Let's better clean this up now.
Actually, it would even be better if we fixed get_adhocservice_by_ivoid to accept a regular expression, because we we really ought to be matching aginst is ivo://ivoa.net/std/SODA#sync-1.\d+; but I'd say that can wait until there is thought of SODA 10.x.
Again, I'd argue this is a minor, preventive bug fix that can do without a changelog entry. SODA 1.1 also is at least one year away, so there's probably no need for backports.