-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: use nightly wheels #353
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
7e6f015
Minor cleanup of the testing header
bsipocz 3c43c3b
Switching to use nightly dev wheels and minor improvements
bsipocz 86f3a52
Coverage should be just another option for the tests
bsipocz 8a85ad3
Update actions versions
bsipocz c9735de
Coverage should be part of a test run and not the stylechecker
bsipocz 52b9e36
removing egg_info builds from CI
bsipocz e101a87
Fixing some syntax issues
bsipocz 488072f
Handling optional dependency, remove the unused one
bsipocz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,7 @@ | |
# as oldestdeps and devastropy might not support the full python range | ||
# listed here | ||
envlist = | ||
py{38,39,310}-test{,-oldestdeps, -devastropy} | ||
py{38,39,310}-test{,-alldeps,-oldestdeps,-devdeps}{-,cov} | ||
egg_info | ||
cov | ||
linkcheck | ||
|
@@ -13,55 +13,40 @@ envlist = | |
requires = | ||
setuptools >= 30.3.0 | ||
pip >= 19.3.1 | ||
tox-pypi-filter >= 0.12 | ||
|
||
[testenv] | ||
pypi_filter = https://raw.githubusercontent.com/astropy/ci-helpers/main/pip_pinnings.txt | ||
|
||
extras = | ||
test | ||
all | ||
|
||
commands = | ||
pip freeze | ||
pytest --pyargs pyvo | ||
alldeps: all | ||
|
||
# tox environments are constructed with so-called 'factors' (or terms) | ||
# separated by hyphens, e.g. test-devdeps-cov. Lines below starting with factor: | ||
# will only take effect if that factor is included in the environment name. To | ||
# see a list of example environments that can be run, along with a description, | ||
# run: | ||
# | ||
# tox -l -v | ||
# | ||
description = | ||
run tests | ||
oldestdeps: with astropy 4.1.* | ||
devastropy: with astropy latest | ||
oldestdeps: with oldest supported dependencies | ||
devdeps: with development version of dependencies | ||
cov: determine the code coverage | ||
|
||
deps = | ||
devastropy: git+https://github.com/astropy/astropy.git#egg=astropy | ||
cov: coverage | ||
|
||
oldestdeps: astropy==4.1 | ||
# We set a suitably old numpy along with an old astropy, no need to pick up | ||
# deprecations and errors due to their unmatching versions | ||
oldestdeps: numpy==1.16 | ||
|
||
[testenv:egg_info] | ||
description = ensure egg_info works without dependencies | ||
commands = | ||
devdeps: pip install -U --pre --only-binary :all: -i https://pypi.anaconda.org/scipy-wheels-nightly/simple numpy | ||
devdeps: pip install -U --pre -i https://pypi.anaconda.org/astropy/simple astropy | ||
|
||
pip freeze | ||
python setup.py egg_info | ||
!cov: pytest --pyargs pyvo | ||
cov: pytest --pyargs pyvo --cov pyvo --cov-config={toxinidir}/setup.cfg | ||
cov: coverage xml -o {toxinidir}/coverage.xml | ||
|
||
[testenv:cov] | ||
description = determine the code coverage | ||
deps: | ||
# had to pin this | ||
coverage==4.5.4 | ||
|
||
[testenv:egg_info] | ||
description = ensure egg_info works without dependencies | ||
commands = | ||
pip freeze | ||
pytest --pyargs pyvo --cov pyvo --cov-config={toxinidir}/setup.cfg | ||
coverage xml -o {toxinidir}/coverage.xml | ||
python setup.py egg_info | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Is this still needed? I think astropy stopped testing this a long time ago. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, I suppose it can go. |
||
|
||
|
||
[testenv:docs] | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stuart proposed another way to do this over at astropy/astropy#13614
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, interesting. That was more like the first approach we had, and then we switched over to having these individual pip installs. I think Stuart's version is cleaner in the case when you have multiple packages. However, here we only use the scipy-wheels-nightly for numpy, and something else for astropy, and don't install other packages. So I would say we should keep it as a one-liner like this rather than adding extras.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's very little to choose between them, so use your favourite, but sunpy uses multiple index URLs with the same pattern https://github.com/sunpy/sunpy/blob/main/tox.ini#L34