Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default for UWS version - Issue #198 #199

Merged
merged 1 commit into from
Dec 17, 2019
Merged

Add default for UWS version - Issue #198 #199

merged 1 commit into from
Dec 17, 2019

Conversation

tomdonaldson
Copy link
Contributor

No description provided.

@tomdonaldson tomdonaldson added this to the v1.1 milestone Dec 17, 2019
@codecov
Copy link

codecov bot commented Dec 17, 2019 •
edited
Loading

Codecov Report

Merging #199 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #199   +/-   ##
=======================================
  Coverage   70.81%   70.81%           
=======================================
  Files          37       37           
  Lines        3910     3910           
=======================================
  Hits         2769     2769           
  Misses       1141     1141
Impacted Files Coverage Δ
pyvo/io/uws/endpoint.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78e3d52...1286544. Read the comment docs.

@tomdonaldson tomdonaldson requested a review from cbanek December 17, 2019 15:48
stargaser
stargaser approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@stargaser stargaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good to me. I've tested the branch against a service.run_async query that was previously failing, and that works fine now.

Minor nits only: one inline, plus I feel like the last two commits could be squashed.

pyvo/io/uws/endpoint.py Outdated
self._version = data.get('version')
# Default to v1.0 since the version attribute
# was not required until version 1.1.
self._version = data.get('version', "1.0")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stylistic point that single quotes and double quotes are used in the same line of code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the requested changes and squashed the commits.

@tomdonaldson
Add default for UWS version - Issue astropy#198
1286544 
Add changelog

Correct PR # in changelog

Fix flake8 errors

Style changes from review
@tomdonaldson tomdonaldson requested a review from a team December 17, 2019 17:03
@tomdonaldson tomdonaldson merged commit ef3dd30 into astropy:master Dec 17, 2019
@stargaser
Copy link
Contributor

🎉

@tomdonaldson tomdonaldson mentioned this pull request Dec 17, 2019
Closed
@tomdonaldson tomdonaldson deleted the uws_default_version branch December 17, 2019 22:24
@cbanek cbanek mentioned this pull request Dec 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbanek cbanek cbanek approved these changes

@stargaser stargaser stargaser approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@tomdonaldson @stargaser @cbanek