Skip to content

Commit

Permalink
MAINT: adding test and changelog for sia2 registry search
Browse files Browse the repository at this point in the history
  • Loading branch information
bsipocz committed Feb 16, 2023
1 parent 0e8a612 commit e00456d
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
``SIA2_PARAMETERS_DESC``. The old names now issue an
``AstropyDeprecationWarning``. [#419]

- Registry search now finds SIA v2 services. [#422]


1.4 (2022-09-26)
================
Expand Down
12 changes: 12 additions & 0 deletions pyvo/registry/tests/test_regtap.py
Original file line number Diff line number Diff line change
Expand Up @@ -776,3 +776,15 @@ def getflashcol(name):

assert (getflashcol("ssa_fluxcalib").description
== "Type of flux calibration")


@pytest.remote_data
def test_sia_registry_searches(self):
# SIA2 services, e.g. Spitzer SEIP were originally not found by the registry search
image_services_v1 = regsearch(servicetype='sia')
image_services_v2 = regsearch(servicetype='sia2')

assert image_services_v1 != image_services_v2

assert len([s.ivoid for s in image_services_v2 if 'spitzer/images/seip' in s.ivoid]) > 0
assert len([s.ivoid for s in image_services_v1 if 'spitzer/images/seip' in s.ivoid]) == 0

0 comments on commit e00456d

Please sign in to comment.