Preserve multiline implicit concatenated strings in docstring positions #15126
+116
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichaReiser
added
formatter
MichaReiser
commented
Dec 23, 2024
crates/ruff_python_formatter/src/expression/expr_string_literal.rs
Outdated
Show resolved
Hide resolved
|
## Summary This is a bug fix for #13928 We failed to preserve multiline implicit concatenated strings that can't be automatically joined in docstring positions: ```py def test(): ( r"This is a docstring" "and Ruff can't automatically join it" ) ``` ## Test plan Added formatter tests
MichaReiser
force-pushed
the
micha/preserve-multiline-implicit-concatenated-string-in-docstrings
branch
from
d9f0ce8 to
edc3bb4
Compare
dhruvmanila
approved these changes
Dec 24, 2024
MichaReiser
deleted the
micha/preserve-multiline-implicit-concatenated-string-in-docstrings
branch
dcreager
added a commit
that referenced
this pull request
Jan 3, 2025
* main: [`ruff`] Avoid reporting when `ndigits` is possibly negative (`RUF057`) (#15234) Attribute panics to the mdtests that cause them (#15241) Show errors for attempted fixes only when passed `--verbose` (#15237) [`RUF`] Add rule to detect empty literal in deque call (`RUF025`) (#15104) TD003: remove issue code length restriction (#15175) Preserve multiline implicit concatenated strings in docstring positions (#15126) [`pyflakes`] Ignore errors in `@no_type_check` string annotations (`F722`, `F821`) (#15215) style(AIR302): rename removed_airflow_plugin_extension as check_airflow_plugin_extension (#15233) [`pylint`] Re-implement `unreachable` (`PLW0101`) (#10891) refactor(AIR303): move duplicate qualified_name.to_string() to Diagnostic argument (#15220) Misc. clean up to rounding rules (#15231) Avoid syntax error when removing int over multiple lines (#15230) Migrate renovate config (#15228) Remove `Type::tuple` in favor of `TupleType::from_elements` (#15218)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a bug fix for #13928
I noticed this when writing up the black deviations document and was very confused until I realized... Oh, it's a docstring!
We failed to preserve multiline implicit concatenated
strings that can't be automatically joined in docstring positions:
Test plan
Added formatter tests