Simplify comparison strategy isLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy
#3694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cookieMr
commented
Dec 8, 2024
| @@ -61,12 +61,12 @@ public boolean arrayContains(Object array, Object value) { | |||
|
|
|||
| @Override | |||
| public boolean isLessThan(Object actual, Object other) { | |||
| return !areEqual(actual, other) && !isGreaterThan(actual, other); | |||
| return !isGreaterThanOrEqualTo(actual, other); | |||
There was a problem hiding this comment.
simple De Morgan's law -> https://en.wikipedia.org/wiki/De_Morgan%27s_laws
cookieMr
commented
Dec 8, 2024
| } | ||
|
|
||
| @Override | ||
| public boolean isLessThanOrEqualTo(Object actual, Object other) { | ||
| return areEqual(actual, other) || isLessThan(actual, other); | ||
| return !isGreaterThan(actual, other); |
There was a problem hiding this comment.
no need to call twice the areEqual (2nd call was negated)
|
Good catch, thanks @cookieMr. |
scordio
changed the title
isLessThan and isLessThanOrEqualTo
scordio
changed the title
isLessThan and isLessThanOrEqualToisLessThan and isLessThanOrEqualTo in AbstractComparisonStrategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List:
Following the contributing guidelines will make it easier for us to review and accept your PR.