Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #392 add support for diagramsnet #393

Merged
merged 5 commits into from
Sep 14, 2022
Merged

resolves #392 add support for diagramsnet #393

merged 5 commits into from
Sep 14, 2022

Conversation

JkbLskw
Copy link
Contributor

@JkbLskw JkbLskw commented Sep 13, 2022

@ggrossetie
Copy link
Member

Thanks!
Could you please add it here as well: https://github.com/Mogztter/asciidoctor-kroki/blob/e7da296bfd6b5d8eb3d98cafa0f3d4101c12e611/ruby/lib/asciidoctor/extensions/asciidoctor_kroki/extension.rb#L108-L132
And you will need to update this test: https://github.com/Mogztter/asciidoctor-kroki/blob/master/ruby/spec/asciidoctor_kroki_spec.rb#L194-L207

@JkbLskw
Copy link
Contributor Author

JkbLskw commented Sep 13, 2022

I've added diagramsnet as supported diagram.

@ggrossetie
Copy link
Member

Looks good, thanks!

@ggrossetie ggrossetie changed the title Issue 392 diagramsnet resolves #392 add support for diagramsnet Sep 14, 2022
@ggrossetie ggrossetie merged commit 059510b into asciidoctor:master Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JkbLskw @ggrossetie