resolves #379 support windows EOL line endings #380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a diagram is using Windows EOL line endings (\r\n) and using include of a stylesheet, an error message is thrown reporting that the file to include cannot be found (because of a remaining \r on the url of the code.) This fix adresses this issue and removes any trailing spaces, \r,\n,\r\n in the resolved include file.
ggrossetie
reviewed
Jul 29, 2022
ggrossetie
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a diagram is using Windows EOL line endings (\r\n) and using include
of a stylesheet, an error message is thrown reporting that the file to
include cannot be found (because of a remaining \r on the url of the
code.)
This fix adresses this issue and removes any trailing spaces, \r,\n,\r\n
in the resolved include file.