You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on the project I have some errors because I'm using Ruby 3.0 and the Rubobop version used by the project is not aware of this version so I get an error message (Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7).
I have update Rubocop and took the opportunity to update the other gems at the same time since they don't have any impact.
After running the auto fix, I manually fixed the issues that have a low impact on the code and disable checks in the files for the other ones, the number of changes seems reasonable.
I also enabled the new rules for Rubocop as suggested bu the doc.
I also added the new rubocop-rake gem since it has no impact but I didn't added rubocop-rspec because it detects a lot of violations which should have a big impact on the code.
If you want I can add it and fix the violations, I wanted to know what you prefer before doing the required work, let me know what you prefer.
Looks good, I would rather leave rubocop-rake out for now. I don't think we need it, one less dependency, one less thing to worry about 😄
I've removed it, I also took the opportunity to bump the required ruby/.ruby-version to make it match the one I added in ruby/.rubocop.yml (I forgot I added it), tell me if you prefer to keep the 2.6 version.
I've removed it, I also took the opportunity to bump the required ruby/.ruby-version to make it match the one I added in ruby/.rubocop.yml (I forgot I added it), tell me if you prefer to keep the 2.6 version.
Perfect, I'm fine with Ruby 2.7.
Ruby 2.6 is already in "security maintenance", so it's probably better to use Ruby 2.7 as the minimum version: https://www.ruby-lang.org/en/downloads/branches/
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When working on the project I have some errors because I'm using Ruby 3.0 and the Rubobop version used by the project is not aware of this version so I get an error message (
Supported versions: 2.3, 2.4, 2.5, 2.6, 2.7).I have update Rubocop and took the opportunity to update the other gems at the same time since they don't have any impact.
After running the auto fix, I manually fixed the issues that have a low impact on the code and disable checks in the files for the other ones, the number of changes seems reasonable.
I also enabled the new rules for Rubocop as suggested bu the doc.
I also added the new
rubocop-rakegem since it has no impact but I didn't addedrubocop-rspecbecause it detects a lot of violations which should have a big impact on the code.If you want I can add it and fix the violations, I wanted to know what you prefer before doing the required work, let me know what you prefer.