Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: View saved addresses in BNMO checkout #6920

Merged
merged 9 commits into from
Jan 26, 2021

Conversation

annacarey
Copy link
Contributor

@annacarey annacarey commented Jan 21, 2021

Updated the schema in Force to get access to the addressConnection. Edited the UI to display the list of addresses and populate them in the component's state when selected.

Screen Shot 2021-01-21 at 12 51 26 PM

https://artsyproduct.atlassian.net/browse/PURCHASE-2300

@annacarey annacarey changed the title WIP DO NOT MERGE: View saved addresses in BNMO checkout DO NOT MERGE: View saved addresses in BNMO checkout Jan 22, 2021
Copy link
Contributor

@sepans sepans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇 🚀 This looks great 💯 A couple of small comments and suggestions. I will pull this PR to do some additional QA before merging it.

src/v2/Apps/Order/Routes/Shipping/index.tsx Outdated Show resolved Hide resolved
src/v2/Apps/Order/Routes/Shipping/index.tsx Outdated Show resolved Hide resolved
src/v2/Apps/Order/Routes/Shipping/index.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@sepans
Copy link
Contributor

sepans commented Jan 25, 2021

I did some more QA and it works great! 🎉 🥇

I found a small problem with populating the country name when 2 saved addresses have different countries but definitely doesn't need to be fixed in this PR (I just wrote it here as a note for myself to check it when working on the Add/Edit address part)

@annacarey annacarey force-pushed the annacarey/view-saved-addresses branch from d071a2a to e1e1c4b Compare January 26, 2021 17:00
@annacarey annacarey changed the title DO NOT MERGE: View saved addresses in BNMO checkout feat: View saved addresses in BNMO checkout Jan 26, 2021
@sepans sepans merged commit 5b6e8bd into master Jan 26, 2021
@sepans sepans deleted the annacarey/view-saved-addresses branch January 26, 2021 18:34
@sepans
Copy link
Contributor

sepans commented Jan 26, 2021

Merged. Thanks again 🙏🏽

@artsy-peril artsy-peril bot mentioned this pull request Jan 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants