-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update OpenShift integration and restore itegration tests #1339
Update OpenShift integration and restore itegration tests #1339
Conversation
0c37afd
to
9a0cb5d
Compare
…r to work with the JKube Maven plugin, which replaces the deprecated Fabric8 Maven plugin
…pt header when checking the version
…ces with JKube Maven plugin for Kubernetes and OpenShift
…> JKubeMavenPluginResourceGeneratorBuilder, and add Openshift logic. Use a different hello-openshift image for OpenShift integration functional tests
…igured _auto_ oauth token into account, too
…ft integration implementation
9a0cb5d
to
472b9ee
Compare
b7479ab
to
29f0330
Compare
…deployed Fix CI steps order to prevent OpenSHift setup step frm wiping the local dir contents
29f0330
to
7d81b90
Compare
…as it fails CI checks on some envs (e.g.: GitHub)
…on and OpenshiftClientResourceProvider
…ntegration work in openshift module Adding ENV VAR to make an old PhantomJS driver work with recent OPENSSL implementation
78fdc3d
to
cafcef4
Compare
5a20bd3
to
47d9502
Compare
c42ff55
to
54dcb48
Compare
…o work with oc v.3 output too (because of CI running on OCP 3.x)
…nternal.ClientResourceProvider in order to skip OpenshiftClient.class, as it could prevent the OpenshiftClientResourceProvider from doing its job
2b2f71f
to
9d4333d
Compare
…aceIT from running in CI
15cc163
to
66ce39a
Compare
… application readiness, i.e. number of desired replicas == available replicas"
d154bbe
to
3030300
Compare
Hi @jimma - could you please review (once you're back, of course 🙂... ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am good with the changes.
Some trivial comments on the year in file head. :)
...src/test/resources/spring-boot/src/main/java/org/eclipse/jkube/maven/sample/Application.java
Show resolved
Hide resolved
Thanks for your review @gaol! |
I am going to merge this, according to the approval received from @gaol, since we do need to have full CI checks running on future changes. |
Short description of what this resolves:
Restore OpenShift integration tests
Changes proposed in this pull request:
See the commit list
Fixes #1323