Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation problem with blockly on reeborg-staging #442

Open
aroberge opened this issue Jul 2, 2018 · 2 comments
Open

Translation problem with blockly on reeborg-staging #442

aroberge opened this issue Jul 2, 2018 · 2 comments

Comments

@aroberge
Copy link
Owner

aroberge commented Jul 2, 2018

When using the version on reeborg-staging, the loop information on two blocks (while and break/continue) is only displayed in Chinese - never updated to other languages.

aroberge added a commit that referenced this issue Jul 2, 2018
@aroberge
Copy link
Owner Author

aroberge commented Jul 2, 2018

This appears to be an issue with Blockly, which I reported. See google/blockly#1964 for details.

@aroberge
Copy link
Owner Author

aroberge commented Jul 3, 2018

I don't really like the suggestions offered on google/blockly#1964: reloading the page would be an annoyance to the users and should not be warranted; the other method would likely require me to build my own blocks with their tools.

What I plan to do instead is go back to their implementation of these blocks before they switch to JSON definitions [1], and incorporate the small amount of Javascript code in my existing blocks definitions [2]

[1] For example: https://github.com/google/blockly/blob/edd3e3bf3350e15f8d34435216c80f19f022401d/blocks/loops.js

[2] https://github.com/aroberge/reeborg/blob/master/src/js/programming_api/blockly.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant