metrics: fix memory leak

fixes ipfs#389 Credit goes to @sidenaio for finding this.
ariescodescream · Sep 4, 2019 · 3d68f5b · 3d68f5b
1 parent a12e621
commit 3d68f5b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/dht_net.go b/dht_net.go
@@ -114,7 +114,7 @@ func (dht *IpfsDHT) handleNewMessage(s network.Stream) bool {
 		timer.Reset(dhtStreamIdleTimeout)
 
 		startTime := time.Now()
-		ctx, _ = tag.New(
+		ctx, _ := tag.New(
 			ctx,
 			tag.Upsert(metrics.KeyMessageType, req.GetType().String()),
 		)

diff --git a/go.mod b/go.mod
@@ -27,3 +27,5 @@ require (
 	go.opencensus.io v0.21.0
 	golang.org/x/xerrors v0.0.0-20190513163551-3ee3066db522
 )
+
+go 1.12
-Original file line number
+Diff line change
@@ Expand Up / @@ -27,3 +27,5 @@ require ( @@
     	go.opencensus.io v0.21.0
     	golang.org/x/xerrors v0.0.0-20190513163551-3ee3066db522
     )
+    go 1.12