-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metricprovider): credentials to download plugin #3905
Conversation
Published E2E Test Results 4 files 4 suites 3h 14m 38s ⏱️ For more details on these failures, see this check. Results for commit 2b091a2. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 285 tests 2 285 ✅ 2m 59s ⏱️ Results for commit 2b091a2. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
+ Coverage 82.69% 82.97% +0.28%
==========================================
Files 163 163
Lines 22895 22914 +19
==========================================
+ Hits 18934 19014 +80
+ Misses 3087 3027 -60
+ Partials 874 873 -1 ☔ View full report in Codecov by Sentry. |
955ac0a
to
cfa0cf8
Compare
Please retry analysis of this Pull-Request directly on SonarCloud |
Signed-off-by: Ariadna Rouco <[email protected]>
Signed-off-by: Ariadna Rouco <[email protected]>
Signed-off-by: Ariadna Rouco <[email protected]>
Signed-off-by: Ariadna Rouco <[email protected]>
Signed-off-by: Ariadna Rouco <[email protected]>
Signed-off-by: Ariadna Rouco <[email protected]>
Quality Gate passedIssues Measures |
Can we create a release with this change in please? This is useful for us to make our plugin private as well. Would also love to have a release made in the argo-helm project for the new version. Thank you! |
* adding logic to defined headers to download plugins from secure sources. Signed-off-by: Ariadna Rouco <[email protected]> * adding documentation for plugin download headers Signed-off-by: Ariadna Rouco <[email protected]> * removing insignificant line. Signed-off-by: Ariadna Rouco <[email protected]> * increasing coverage Signed-off-by: Ariadna Rouco <[email protected]> * adding coverage. Signed-off-by: Ariadna Rouco <[email protected]> * malformed url case coverage. Signed-off-by: Ariadna Rouco <[email protected]> --------- Signed-off-by: Ariadna Rouco <[email protected]>
In our company, we have a use case where we need to create a new plugin as a metric provider. For security reasons the plugin needs to be private and cannot be uploaded to a public storage.
Therefore, we have the need to use credentials for downloading the plugin securely.
We have followed k8s secretRef pattern to specify how the credentials are passed.
Additionally, we had an issue with 404 status code. The downloader says that the plugin is downloaded correctly but it’s not true.
Fixes: #3708
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.