malformed url case coverage.

Signed-off-by: Ariadna Rouco <[email protected]>
argoproj · Oct 23, 2024 · cfa0cf8 · cfa0cf8
1 parent 2b3cc0b
commit cfa0cf8
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/utils/plugin/downloader_test.go b/utils/plugin/downloader_test.go
@@ -318,13 +318,13 @@ func TestCheckShaOfPlugin(t *testing.T) {
 
 func TestDownloadFile(t *testing.T) {
 	t.Run("test sha of real file", func(t *testing.T) {
-		err := downloadFile("error", "", FileDownloaderImpl{}, nil)
+		err := downloadFile("error", " ", FileDownloaderImpl{}, nil)
 		assert.Error(t, err)
 		assert.Contains(t, err.Error(), "failed to download file from")
 	})
 
 	t.Run("test download fail with invalid url", func(t *testing.T) {
-		url := "http://\x07World"
+		url := "://example.com"
 		err := downloadFile("error", url, FileDownloaderImpl{}, nil)
 		assert.Error(t, err)
 		assert.Contains(t, err.Error(), "failed to download file from")