feat(appset): grab the application status from redis #21455
Draft
+155
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urceHealth is false Signed-off-by: rumstead <[email protected]>
❗ Preview Environment deployment failed on BunnyshellSee: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
rumstead
commented
Jan 10, 2025
| statusMap := appsetstatus.GetResourceStatusMap(appset) | ||
| statusMap = appsetstatus.BuildResourceStatus(statusMap, apps) | ||
| // if any application uses apptree instead of inline, grab all the statuses from the cache instead of the CRs | ||
| isAppTree := appsetstatus.AppsUseAppTree(apps) |
There was a problem hiding this comment.
I guess I could expose the config from argocd-cmd-params-cm to the server and pass it all the way down but we are already doing a check like this for applications in the server.
rumstead
commented
Jan 10, 2025
| cache, err := cacheSource() | ||
| errors.CheckError(err) | ||
| var appStatusProvider status.AppResourceStatusProvider | ||
| if persistResourceHealth { |
There was a problem hiding this comment.
Instead of passing down persistResourceHealth I could also check each application for ResourceHealthLocationAppTree and if one application has it, grab all the resources from redis.
rumstead
commented
Jan 10, 2025
| valueFrom: | ||
| configMapKeyRef: | ||
| name: argocd-cmd-params-cm | ||
| key: controller.resource.health.persist |
There was a problem hiding this comment.
intentionally using controller. vs applicationset. since we would want the user to only configure this once to enable it.
rumstead
commented
Jan 10, 2025
| @@ -841,7 +839,6 @@ const ( | |||
| ApplicationSetReasonErrorOccurred = "ErrorOccurred" | |||
| ApplicationSetReasonApplicationSetUpToDate = "ApplicationSetUpToDate" | |||
| ApplicationSetReasonParametersGenerated = "ParametersGenerated" | |||
| ApplicationSetReasonApplicationGenerated = "ApplicationGeneratedSuccessfully" | |||
rumstead
commented
Jan 10, 2025
| @@ -851,7 +848,6 @@ const ( | |||
| ApplicationSetReasonApplicationValidationError = "ApplicationValidationError" | |||
| ApplicationSetReasonApplicationSetModified = "ApplicationSetModified" | |||
| ApplicationSetReasonApplicationSetRolloutComplete = "ApplicationSetRolloutComplete" | |||
| ApplicationSetReasonSyncApplicationError = "SyncApplicationError" | |||
Signed-off-by: rumstead <[email protected]>
Signed-off-by: rumstead <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10312
Checklist: