chore: enable unnecessary-stmt from revive #21398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthieu MOREL <[email protected]>
❌ Preview Environment deleted from BunnyshellAvailable commands (reply to this comment):
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21398 +/- ##
==========================================
+ Coverage 55.16% 55.25% +0.08%
==========================================
Files 337 337
Lines 57039 57034 -5
==========================================
+ Hits 31464 31512 +48
+ Misses 22874 22825 -49
+ Partials 2701 2697 -4 ☔ View full report in Codecov by Sentry. |
nitishfy
reviewed
Jan 7, 2025
| } | ||
| if issuedAtTime, err := jwtutil.IssuedAtTime(claims); err == nil { | ||
| rvalsStrs = append(rvalsStrs, "iat: "+issuedAtTime.Format(time.RFC3339)) | ||
| if err == nil { |
There was a problem hiding this comment.
Suggested change
| if err == nil { | |
| if err == nil { |
we should also check for the case when err is non-nil
There was a problem hiding this comment.
What do you suggest here ?
There was a problem hiding this comment.
I think the change is fine, although it reads a little weird. Looks functionally identical to before.
crenshaw-dev
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
unnecessary-stmt: This rule suggests to remove redundant statements like a break at the end of a case block, for improving the code's readability.