chore: enable receiver-naming from revive

[mmorel-35]

Description

receiver-naming: By convention, receiver names in a method should reflect their identity. For example, if the receiver is of type Parts, p is an adequate name for it. Contrary to other languages, it is not idiomatic to name receivers as this or self.

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

Attention: Patch coverage is 72.11982% with 121 lines in your changes missing coverage. Please review.

Project coverage is 55.26%. Comparing base (cb3024c) to head (b61f361).

Files with missing lines	Patch %	Lines
server/server.go	70.27%	44 Missing and 11 partials ⚠️
pkg/apis/application/v1alpha1/repository_types.go	23.33%	23 Missing ⚠️
pkg/apis/application/v1alpha1/app_project_types.go	47.61%	22 Missing ⚠️
pkg/apis/application/v1alpha1/types.go	88.27%	15 Missing and 2 partials ⚠️
controller/sharding/cache.go	83.33%	2 Missing ⚠️
util/git/creds.go	90.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #21372      +/-   ##
==========================================
+ Coverage   55.20%   55.26%   +0.05%     
==========================================
  Files         337      337              
  Lines       57039    57039              
==========================================
+ Hits        31490    31521      +31     
+ Misses      22847    22821      -26     
+ Partials     2702     2697       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[reggie-k]

Thanks for the PR! Those variable names are definitely clearer than before.

I think we can be even more consistent about the variable names: server *ArgoCDServer VS c HTTPSCreds VS ag *ApplicationGenerator - if the consideration for server was that argoCDServer is too long and it was always choosing the last word, then maybe creds HTTPSCreds? And maybe generator instead of ag , like in sharding *ClusterSharding?