Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: OpenUnison integration; fix portal screen shot and linked to the open source website #21179

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mlbiam
Copy link
Contributor

@mlbiam mlbiam commented Dec 14, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@mlbiam mlbiam requested review from a team as code owners December 14, 2024 18:29
Copy link

bunnyshell bot commented Dec 14, 2024

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

@mlbiam mlbiam changed the title OpenUnison integration docs: fix portal screen shot and linked to the open source website docs - OpenUnison integration: fix portal screen shot and linked to the open source website Dec 15, 2024
@mlbiam mlbiam changed the title docs - OpenUnison integration: fix portal screen shot and linked to the open source website docs: OpenUnison integration; fix portal screen shot and linked to the open source website Dec 15, 2024
Copy link
Member

@nitishfy nitishfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit Overall LGTM.

lgtm

Co-authored-by: Nitish Kumar <[email protected]>
Signed-off-by: Marc Boorshtein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants