Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Populate destination name when destination server is specified (#21063) (cherry-pick 2.13) #21176

Conversation

adriananeci
Copy link
Contributor

Manually cherry-picking #21063 into 2.13 release branch since automatic flow didn't work and failed with

Cherry-pick failed with Merge error 030a7be7e2fd0ae976c9b73196d777ea72bada09 into temp-cherry-pick-cc74e0-release-2.13

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

adriananeci and others added 2 commits December 14, 2024 10:35
…rgoproj#21063)

* Populate destination name when destination server is specified

Signed-off-by: Adrian Aneci <[email protected]>

---------

Signed-off-by: Adrian Aneci <[email protected]>
Signed-off-by: Adrian Aneci <[email protected]>
@adriananeci adriananeci force-pushed the temp-cherry-pick-030a7be-release-2.13 branch from e352bd7 to f64e01e Compare December 14, 2024 08:35
@gdsoumya gdsoumya merged commit 079754c into argoproj:release-2.13 Dec 14, 2024
18 of 19 checks passed
@adriananeci adriananeci deleted the temp-cherry-pick-030a7be-release-2.13 branch December 14, 2024 09:29
Copy link

codecov bot commented Dec 14, 2024

Codecov Report

Attention: Patch coverage is 60.86957% with 27 lines in your changes missing coverage. Please review.

Project coverage is 55.01%. Comparing base (b6af657) to head (f64e01e).
Report is 2 commits behind head on release-2.13.

Files with missing lines Patch % Lines
applicationset/utils/clusterUtils.go 57.14% 6 Missing and 3 partials ⚠️
util/argo/argo.go 65.38% 6 Missing and 3 partials ⚠️
server/application/application.go 0.00% 5 Missing ⚠️
pkg/apis/application/v1alpha1/types.go 76.47% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-2.13   #21176      +/-   ##
================================================
- Coverage         55.02%   55.01%   -0.01%     
================================================
  Files               320      320              
  Lines             54754    54816      +62     
================================================
+ Hits              30126    30157      +31     
- Misses            22044    22058      +14     
- Partials           2584     2601      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants