Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Graceful shutdown for the API server (#18642) (cherry-pick #20981) #21099

Closed

Conversation

gcp-cherry-pick-bot[bot]
Copy link

Cherry-picked fix: Graceful shutdown for the API server (#18642) (#20981)

Closes #18642

Implements a graceful shutdown the the API server. Without this, ArgoCD API server will eventually return 502 during rolling update. However, healthcheck would return 503 if the server is terminating.

Signed-off-by: Andrii Korotkov [email protected]
Co-authored-by: Leonardo Luz Almeida [email protected]
Co-authored-by: Michael Crenshaw [email protected]

  • Init server only once, but keep re-initializing listeners

Signed-off-by: Andrii Korotkov [email protected]

  • Check error for SetParamInSettingConfigMap as needed after fresh master

Signed-off-by: Andrii Korotkov [email protected]

  • Prevent a data race

Signed-off-by: Andrii Korotkov [email protected]

  • Remove unused variable, don't pass lock when not necessary

Signed-off-by: Andrii Korotkov [email protected]

  • Try overriding URL instead of additional URLs

Signed-off-by: Andrii Korotkov [email protected]

  • Use a more specific url

Signed-off-by: Andrii Korotkov [email protected]


Signed-off-by: Andrii Korotkov [email protected]
Co-authored-by: Leonardo Luz Almeida [email protected]
Co-authored-by: Michael Crenshaw [email protected]

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot requested a review from a team as a code owner December 9, 2024 09:46
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot force-pushed the cherry-pick-334e47-release-2.13 branch from 8e7386c to 01ae20d Compare December 9, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants