no more default devnet VK; it should now be set manually via GenesisConfiguration during (re)deployment #15704
+92
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The genesis VK for Aptos Keyless is either set manually via
GenesisConfiguration
or defaults to theDEVNET_VERIFICATION_KEY
value hardcoded in our Rust code.However, this default value is no longer useful1, because when we update the devnet VK in production, a devnet redeployment would later overwrite this update and revert us back to the default VK.
This, in turn, would lock developers outside of their devnet accounts. As result, we'd have to manually run a governance proposal to update the devnet VK after every devnet release.
Therefore, to ensure VK updates persist on devnet, we need to refine our devnet deployment process to fetch the latest VK from somewhere (TBD) and deploy with that in the
GenesisConfiguration
.We will work with the @aptos-labs/prod-eng team to refine the devnet release process (either in this PR or another).
TODO: For now, leaving this PR as a draft to see what breaks in CI and to discuss with PE team on best path forward.
How Has This Been Tested?
Not yet tested.
Key Areas to Review
TBD.
Type of Change
Which Components or Systems Does This Change Impact?
Checklist
Footnotes
I think the hardcoded devnet VK was useful during the initial keyless development and deployment. ↩