Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no more default devnet VK; it should now be set manually via GenesisConfiguration during (re)deployment #15704

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alinush
Copy link
Contributor

@alinush alinush commented Jan 10, 2025

Description

The genesis VK for Aptos Keyless is either set manually via GenesisConfiguration or defaults to the DEVNET_VERIFICATION_KEY value hardcoded in our Rust code.

However, this default value is no longer useful1, because when we update the devnet VK in production, a devnet redeployment would later overwrite this update and revert us back to the default VK.

This, in turn, would lock developers outside of their devnet accounts. As result, we'd have to manually run a governance proposal to update the devnet VK after every devnet release.

Therefore, to ensure VK updates persist on devnet, we need to refine our devnet deployment process to fetch the latest VK from somewhere (TBD) and deploy with that in the GenesisConfiguration.

We will work with the @aptos-labs/prod-eng team to refine the devnet release process (either in this PR or another).

TODO: For now, leaving this PR as a draft to see what breaks in CI and to discuss with PE team on best path forward.

How Has This Been Tested?

Not yet tested.

Key Areas to Review

TBD.

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Performance improvement
  • Refactoring
  • Dependency update
  • Documentation update
  • Tests

Which Components or Systems Does This Change Impact?

  • Validator Node
  • Full Node (API, Indexer, etc.)
  • Move/Aptos Virtual Machine
  • Aptos Framework
  • Aptos CLI/SDK
  • Developer Infrastructure
  • Move Compiler
  • Other (specify)

Checklist

  • I have read and followed the CONTRIBUTING doc
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I identified and added all stakeholders and component owners affected by this change as reviewers
  • I tested both happy and unhappy path of the functionality
  • I have made corresponding changes to the documentation

Footnotes

  1. I think the hardcoded devnet VK was useful during the initial keyless development and deployment.

Copy link

trunk-io bot commented Jan 10, 2025

⏱️ 1h 39m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟩
rust-move-tests 14m 🟩
rust-move-tests 13m 🟩
rust-cargo-deny 13m 🟩🟩🟩🟩 (+3 more)
rust-move-tests 10m 🟥
rust-move-tests 10m 🟥
check-dynamic-deps 9m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-tests 5m
general-lints 4m 🟩🟩🟩🟩🟩 (+3 more)
semgrep/ci 3m 🟩🟩🟩🟩🟩 (+3 more)
file_change_determinator 2m 🟩🟩🟩🟩🟩 (+3 more)
rust-move-tests 1m
rust-move-tests 51s
permission-check 24s 🟩🟩🟩🟩🟩 (+3 more)
permission-check 19s 🟩🟩🟩🟩🟩 (+3 more)

settingsfeedbackdocs ⋅ learn more about trunk.io

@alinush alinush force-pushed the alin/remove-devnet-vk branch from 3418655 to b33205a Compare January 10, 2025 00:22
@alinush alinush changed the title no more default devnet VK; it should now be set manually via GenesisConfiguration or governance no more default devnet VK; it should now be set manually via GenesisConfiguration during deployment Jan 10, 2025
@alinush alinush changed the title no more default devnet VK; it should now be set manually via GenesisConfiguration during deployment no more default devnet VK; it should now be set manually via GenesisConfiguration during (re)deployment Jan 10, 2025
@alinush alinush force-pushed the alin/remove-devnet-vk branch from b33205a to 2b18655 Compare January 10, 2025 00:44
@alinush alinush force-pushed the alin/remove-devnet-vk branch 4 times, most recently from 951a286 to dbb1c3a Compare January 10, 2025 20:52
@alinush alinush force-pushed the alin/remove-devnet-vk branch from dbb1c3a to fa0ee3e Compare January 10, 2025 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant