Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP [Network] Add new metrics to the network stack. #15623

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

WIP [Network] Add new metrics to the network stack. #15623

wants to merge 1 commit into from

Conversation

JoshLind
Copy link
Contributor

No description provided.

@JoshLind
[Network] Add application send time to message.
7279be3 
[Network] Add application send time to outbound RPC request.

[Network] Add metrics for queuing time.

[Network] Add enum for message metadata.

[Network] Add metrics for received messages.

[Network] Add test helper methods for NetworkMessage.

[Network] Make RpcRequest object self-contained.

[Network] Make DirectSendMsg object self-contained.

[Network] Make RpcResponse object self-contained.

[Network] Add new message types with metadata.

[Network] Handle new message types.

[Network] Support message with metadata transmission.

[Network] Add metrics for transport latencies.

[Network] Update unit tests.
@trunk-io Trunk.io
Copy link

trunk-io bot commented Dec 17, 2024 •
edited
Loading

⏱️ 33m total CI duration on this PR
Job Cumulative Duration Recent Runs
rust-move-tests 14m 🟩 
rust-move-tests 5m ⬜ 
test-target-determinator 5m 🟩 
rust-cargo-deny 4m 🟩 🟩 
check-dynamic-deps 3m 🟩 🟩 
general-lints 53s 🟩 🟩 
semgrep/ci 50s 🟩 🟩 
file_change_determinator 21s 🟩 🟩 
file_change_determinator 13s 🟩 
permission-check 6s 🟩 🟩 
permission-check 5s 🟩 🟩 
permission-check 3s 🟩 
determine-docker-build-metadata 2s 🟩 

🚨 1 job on the last run was significantly faster/slower than expected

Job Duration vs 7d avg Delta
check-dynamic-deps 3m 1m +102%

settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io

@JoshLind JoshLind added the CICD:run-forge-e2e-perf Run the e2e perf forge only label Dec 17, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

✅ Forge suite realistic_env_max_load success on 7279be36ded4c45dc0ce1a94906640b0e488f5a8

two traffics test: inner traffic : committed: 14705.68 txn/s, latency: 2698.91 ms, (p50: 2700 ms, p70: 2700, p90: 3000 ms, p99: 3900 ms), latency samples: 5591420
two traffics test : committed: 99.93 txn/s, latency: 1419.05 ms, (p50: 1400 ms, p70: 1400, p90: 1500 ms, p99: 2700 ms), latency samples: 1680
Latency breakdown for phase 0: ["MempoolToBlockCreation: max: 1.564, avg: 1.498", "ConsensusProposalToOrdered: max: 0.309, avg: 0.290", "ConsensusOrderedToCommit: max: 0.376, avg: 0.366", "ConsensusProposalToCommit: max: 0.666, avg: 0.656"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.16s no progress at version 37539 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 0.70s no progress at version 5789544 (avg 0.64s) [limit 16].
Test Ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zekun000 zekun000 Awaiting requested review from zekun000 zekun000 will be requested when the pull request is marked ready for review zekun000 is a code owner

@bchocho bchocho Awaiting requested review from bchocho bchocho will be requested when the pull request is marked ready for review bchocho is a code owner

@sasha8 sasha8 Awaiting requested review from sasha8 sasha8 will be requested when the pull request is marked ready for review sasha8 is a code owner

@ibalajiarun ibalajiarun Awaiting requested review from ibalajiarun ibalajiarun will be requested when the pull request is marked ready for review ibalajiarun is a code owner

@gregnazario gregnazario Awaiting requested review from gregnazario gregnazario will be requested when the pull request is marked ready for review gregnazario is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
CICD:run-forge-e2e-perf Run the e2e perf forge only
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshLind