In-Memory Cache Crate

[just-in-chang]

Description

Design

Test Plan

Unit tests

[trunk-io]

⏱️ 9h 55m total CI duration on this PR

Job	Cumulative Duration	Recent Runs
rust-unit-tests	3h 14m	⬜ 🟩 🟩 🟩 🟩 (+3 more)
windows-build	3h 3m	🟩 🟩 🟩 🟩 🟩 (+4 more)
run-tests-main-branch	56m	🟥 🟩 🟩 🟩 🟩 (+5 more)
rust-lints	48m	⬜ 🟩 🟩 🟩 🟩 (+3 more)
test-fuzzers	37m	🟩
check	32m	🟩 🟩 🟩 🟩 🟩 (+4 more)
check-dynamic-deps	18m	🟩 🟩 🟩 🟩 🟩 (+5 more)
general-lints	18m	🟩 🟩 🟩 🟩 🟩 (+3 more)
semgrep/ci	4m	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
file_change_determinator	2m	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	38s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	32s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	29s	🟩 🟩 🟩 🟩 🟩 (+4 more)
permission-check	24s	🟩 🟩 🟩 🟩 🟩 (+4 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
rust-unit-tests	39m	31m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

[larry-aptos]

From the discussion, to avoid burst of garbage collection, we could set the eviction size close to target size.

like eviction size = 110% * target size.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.4%. Comparing base (0b9eb46) to head (6c8a517).
Report is 27 commits behind head on main.

❗ Current head 6c8a517 differs from pull request most recent head 8dcf743

Please upload reports for the commit 8dcf743 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff            @@
##             main   #12312     +/-   ##
=========================================
- Coverage    59.0%    58.4%   -0.6%     
=========================================
  Files         817      821      +4     
  Lines      197089   197406    +317     
=========================================
- Hits       116316   115410    -906     
- Misses      80773    81996   +1223     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bowenyang007]

Pushing back to your queue. General feedback is to document a lot more. Would also be helpful to highlight the design choices directly in code b/c we'll surely forget.

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[larry-aptos]

mark it not stale

[github-actions]

This issue is stale because it has been open 45 days with no activity. Remove the stale label, comment or push a commit - otherwise this will be closed in 15 days.

[just-in-chang]

Let's just close this for now until we need to revisit it later 👍