fix: Updating the click functionalities in list item component #38453
Conversation
WalkthroughThe pull request introduces modifications to several components across the design system and application, primarily focusing on simplifying event handling in the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
github-actions
bot
added
Bug
|
/build-deploy-preview skip-tests=true |
|
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/12582233225. |
hetunandu
added
ok-to-test
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
app/client/packages/design-system/ads/src/List/List.tsx (3)
100-102: Consider both stopPropagation and preventDefault for clarity.Stopping the event propagation alone ensures that the parent
onClickhandler does not fire, but if there's any default browser action (e.g., link or button) intended on this control, it might be worth also preventing the default event if needed.
111-111: Revisit keyboard accessibility fallback.By focusing solely on
onClick, there's a risk of excluding keyboard-only users who may rely on the “Enter” or “Space” keys. Consider either restoring a keydown handler or adopting a suitable ARIA role for better accessibility.
152-154: Ensure consistent naming or doc clarity.
handleRightControlClickaccurately describes the event, but adding a quick comment or docstring explaining why the event is stopped helps new collaborators grasp the interaction logic more quickly.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
app/client/packages/design-system/ads/src/List/List.tsx(2 hunks)app/client/packages/design-system/ads/src/Templates/IDEHeader/IDEHeader.stories.tsx(0 hunks)app/client/src/pages/Editor/CustomWidgetBuilder/Preview/Debugger/helpDropdown.tsx(0 hunks)app/client/src/pages/Editor/IDE/EditorPane/components/Group.tsx(0 hunks)
💤 Files with no reviewable changes (3)
- app/client/packages/design-system/ads/src/Templates/IDEHeader/IDEHeader.stories.tsx
- app/client/src/pages/Editor/CustomWidgetBuilder/Preview/Debugger/helpDropdown.tsx
- app/client/src/pages/Editor/IDE/EditorPane/components/Group.tsx
|
Deploy-Preview-URL: https://ce-38453.dp.appsmith.com |
## Description Updating the click functionalities in list item component to fix the partial clickable issue on JS module instance editor in EE. Fixes [#38444](#38444) ## Automation /ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE" ### 🔍 Cypress test results <!-- This is an auto-generated comment: Cypress test results --> > [!TIP] > 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉 > Workflow run: <https://github.com/appsmithorg/appsmith/actions/runs/12582242512> > Commit: a936b58 > <a href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=12582242512&attempt=2" target="_blank">Cypress dashboard</a>. > Tags: `@tag.Sanity, @tag.Datasource, @tag.IDE` > Spec: > <hr>Thu, 02 Jan 2025 14:17:45 UTC <!-- end of auto-generated comment: Cypress test results --> ## Communication Should the DevRel and Marketing teams inform users about this change? - [ ] Yes - [ ] No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Refactor** - Removed `description` and `descriptionType` properties from various `List` component items across multiple components - Simplified keyboard interaction model in `List` component by removing keyboard event handling - Modified click event handling in `ListItem` to focus on mouse interactions - **Bug Fixes** - Prevented event propagation for right control clicks in `ListItem` <!-- end of auto-generated comment: release notes by coderabbit.ai -->
fix: Updating the click functionalities in list item component (#38453)
Description
Updating the click functionalities in list item component to fix the partial clickable issue on JS module instance editor in EE.
Fixes #38444
Automation
/ok-to-test tags="@tag.Sanity, @tag.Datasource, @tag.IDE"
🔍 Cypress test results
Tip
🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
Workflow run: https://github.com/appsmithorg/appsmith/actions/runs/12582242512
Commit: a936b58
Cypress dashboard.
Tags:
@tag.Sanity, @tag.Datasource, @tag.IDESpec:
Thu, 02 Jan 2025 14:17:45 UTC
Communication
Should the DevRel and Marketing teams inform users about this change?
Summary by CodeRabbit
Refactor
descriptionanddescriptionTypeproperties from variousListcomponent items across multiple componentsListcomponent by removing keyboard event handlingListItemto focus on mouse interactionsBug Fixes
ListItem