Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Button widget overflows from the canvas even on preview mode #33537

Closed
1 task done
ramsaptami opened this issue May 17, 2024 · 1 comment
Closed
1 task done

[Bug]: Button widget overflows from the canvas even on preview mode #33537

ramsaptami opened this issue May 17, 2024 · 1 comment
Assignees
@KelvinOm
Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users WDS team

Comments

@ramsaptami
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Description

Button widget overflows from canvas boundary even on preview mode as seen in the image

Steps To Reproduce

image

Public Sample App

No response

Environment

Deploy Preview

Severity

High (Blocker to building or releasing)

Issue video log

No response

Version

cloud
@ramsaptami ramsaptami added Bug Something isn't working WDS team labels May 17, 2024
@Nikhil-Nandagopal Nikhil-Nandagopal added Deploy Preview Issues found in Deploy Preview High This issue blocks a user from building or impacts a lot of users labels May 17, 2024
@github-actions github-actions bot added the Anvil Pod Issue related to Anvil project label May 17, 2024
@KelvinOm KelvinOm self-assigned this May 17, 2024
@raza001
Copy link
Contributor

raza001 commented May 17, 2024

Pls Attach video if possible @ramsaptami

@KelvinOm KelvinOm mentioned this issue Jun 4, 2024
Merged
2 tasks
KelvinOm added a commit that referenced this issue Jun 6, 2024
@KelvinOm
fix: widget overflow behaviour in anvil (#33961)
05aa9cc 
## Description
Fixed overflow operation for widgets in zones.


Fixes 
#32922 
#33537 

## Automation

/ok-to-test tags="@tag.Anvil"

### 🔍 Cypress test results
<!-- This is an auto-generated comment: Cypress test results  -->
> [!TIP]
> 🟢 🟢 🟢 All cypress tests have passed! 🎉 🎉 🎉
> Workflow run:
<https://github.com/appsmithorg/appsmith/actions/runs/9386697113>
> Commit: e0f8f24
> Cypress dashboard url: <a
href="https://internal.appsmith.com/app/cypress-dashboard/rundetails-65890b3c81d7400d08fa9ee5?branch=master&workflowId=9386697113&attempt=1"
target="_blank">Click here!</a>

<!-- end of auto-generated comment: Cypress test results  -->






## Communication
Should the DevRel and Marketing teams inform users about this change?
- [ ] Yes
- [x] No


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced dynamic font size customization using CSS custom
properties.

- **Improvements**
- Adjusted layout behavior for `AnvilFlexComponent` to use `fit-content`
for better content fitting.
- Enhanced styling for elements with elevation property, including font
size and spacing adjustments.
- Switched to `isEditOnlyModeSelector` for more accurate layout wrapping
behavior in `SectionRow`.

- **Removals**
- Removed `renderMode` property from `BaseLayoutComponent`,
`FlexLayoutProps`, and related components for streamlined functionality.
  - Simplified imports and prop handling in `AlignedWidgetRowComp`.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@KelvinOm KelvinOm closed this as completed Jun 6, 2024
@ramsaptami ramsaptami removed the Deploy Preview Issues found in Deploy Preview label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KelvinOm KelvinOm

Labels
Anvil Pod Issue related to Anvil project Bug Something isn't working High This issue blocks a user from building or impacts a lot of users WDS team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Nikhil-Nandagopal @KelvinOm @raza001 @ramsaptami