Support validation parameters for service:check #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaxleyiii
reviewed
Feb 1, 2019
packages/apollo/package.json
Outdated
| @@ -60,6 +60,7 @@ | |||
| "heroku-cli-util": "^8.0.9", | |||
| "listr": "^0.14.1", | |||
| "lodash": "^4.17.10", | |||
| "moment": "^2.24.0", | |||
There was a problem hiding this comment.
Can we use something lighter than moment like date-fns?
There was a problem hiding this comment.
Looked for anything to support durations with the ease-of-use + granularity that ISO 8601 gives us and no love, + discussed offline. Going to leave as is. If having moment gets too heavy, we can write a duration parser.
jbaxleyiii
reviewed
Feb 1, 2019
trevor-scheer
force-pushed
the
trevor/service-check-moment
branch
from
885b61c to
e1f4974
Compare
* validationPeriod - the duration (from now) to validate the service against * queryCountThreshold - minimum number of requests within the requested time window for a query to be considered * queryCountThresholdPercentage - number of requests within the requested time window for a query to be considered, relative to total request count.
Throw errors from the response if we have them, then throw the generic error if no data is provided. Previously, the order of these were swapped, meaning that if a specific error came back from the server, we would still throw the generic error.
trevor-scheer
force-pushed
the
trevor/service-check-moment
branch
from
e1f4974 to
1399b04
Compare
jbaxleyiii
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds functionality for 3 new flags in the service:check command:
Also included in this PR - better error messaging:
EngineClient, so that errors reported from the service will be thrownwith priority over the generic "noServiceError" when data isn't present.
TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.