-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve vscode marketplace appearance #942
Conversation
packages/vscode-apollo/README.md
Outdated
<img src="./images/marketplace/jump-to-def.gif" width="80%" style="margin: 5%" alt="Using jump to definition on a fragment"> | ||
|
||
<h3 id="commands">Apollo commands</h3> | ||
The VS Code extension integrates with the VS Code command palate and provides two commands currently: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This list is another "thing" that would probably become dated as we change and add commands. Though we don't currently have a docs "source of truth" the way we do for config, so go with what you think is best here...I don't feel too strongly.
2342485
to
b794e44
Compare
@JakeDawkins - just wanted to point out a super small typo (but could be a big "copy & paste" timesaver)... missing a comma at https://github.com/apollographql/apollo-tooling/blame/master/packages/vscode-apollo/README.md#L84 I know I could fork, commit, PR, etc. but for a single |
Fix missing comma in code example, as pointed out by @mountainash #942 (comment)
Thanks @mountainash! We don't publish the extension often, but this fix will land the next time we do. |
resolves #816
🔼 (what the marketplace header looks like now)
🔼 (what the marketplace header would look like with these changes)
What I did:
TODO: