Allow GitLab remote URLs in sanitizeGitRemote() #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sachindshinde
force-pushed
the
sachin/safelist-gitlab-in-sanitizeGitRemote
branch
from
5834fd8 to
258ee5e
Compare
jsegaran
approved these changes
Sep 17, 2020
JakeDawkins
approved these changes
Sep 18, 2020
sachindshinde
force-pushed
the
sachin/safelist-gitlab-in-sanitizeGitRemote
branch
from
258ee5e to
447e1a4
Compare
sachindshinde
deleted the
sachin/safelist-gitlab-in-sanitizeGitRemote
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that the backend properly sanitizes remote URLs, we don't have to worry about GitLab remote URLs containing sensitive information. This PR adds GitLab back to the safelist for remote URLs in
sanitizeGitRemote().TODO: