Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error when ENGINE_API_KEY and APOLLO_KEY are found #1893

Merged
merged 4 commits into from
Jun 3, 2020

Conversation

JakeDawkins
Copy link
Contributor

apollo-server still uses the ENGINE_API_KEY, so we can't truly move to the newer key. We have to be able to support both keys for now, so this removes the error and replaces it with a warning that explicitly states which key tooling is using.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

@JakeDawkins JakeDawkins requested a review from zionts April 13, 2020 16:18
Copy link
Contributor

@zionts zionts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me! I made a corresponding update to apollo server: apollographql/apollo-server@a83a1f5

@JakeDawkins JakeDawkins merged commit abedfb2 into master Jun 3, 2020
@JakeDawkins JakeDawkins deleted the jake/update-key-deprecations branch June 3, 2020 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants