Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "hidden: true" from variant flag in service:push #1865

Merged
merged 1 commit into from
Apr 2, 2020

Conversation

sachindshinde
Copy link
Contributor

@sachindshinde sachindshinde commented Apr 1, 2020

When running npx apollo service:push --help, there is no entry for --variant, due to hidden: true being used in the options for the flag (#1849). This PR removes the hidden: true.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

Copy link
Contributor

@zionts zionts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thank you for making this fix.

@zionts
Copy link
Contributor

zionts commented Apr 1, 2020

FWIW I don't think this needs a changelog entry.

@JakeDawkins JakeDawkins merged commit 8daff86 into master Apr 2, 2020
@JakeDawkins JakeDawkins deleted the sachin/fix-service-push-hidden-variant branch April 2, 2020 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants