-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for --graph flag #1858
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a --graph flag (alias -g) which can be set for all CLI commands. There is no handling in this commit.
Additionally, run prettier, do some minor clean-up and inlining of variables that are only used once
Also support servicee specifier in the service.name field
Prettier did this. I blame prettier.
Also add a test to that effect
zionts
changed the title
Add support for --graph flag (and bug fixes)
Add support for --graph flag
Mar 28, 2020
JakeDawkins
approved these changes
Mar 30, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the
--graph
(alias -g) flag to all commands. This will allow users to specify a graph without needing to create anapollo.config.js
file, which will lead to a smoother on-boarding ramp for first-time users. Additionally, this PR contains a bug fix forapollo.config.js
files of theservice
type, where specifying a variant is supported equally as to client projects.For example, a config like so:
will be parsed as graph = github , variant = prod, just as with client projects (which were supported in that fashion before this PR)
There aren't tests for any of the
client:
commands, but I added a test for the additional functionality and did manual QA of my changes. Here is a small sampling and happy to provide additional:service:list
working with a --graph flag and a user token:client:check
working with a --graph flag and an apollo.config.js that does not have aservice
key:client:codegen
working with a --graph flag and an apollo.config.js that does not have aservice
key:TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.