Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation to service delete commmand #1826

Merged
merged 5 commits into from
Mar 5, 2020

Conversation

kkemple
Copy link
Contributor

@kkemple kkemple commented Mar 4, 2020

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

This PR adds a confirmation to the service:delete command in the CLI.

@apollo-cla
Copy link

@kkemple: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/

@kkemple kkemple requested a review from JakeDawkins March 4, 2020 01:15
@kkemple kkemple merged commit fb6aa6e into master Mar 5, 2020
@kkemple kkemple deleted the service-delete-confirmation branch March 5, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants