Fix client localSchemaFile for vscode stats command #1634
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you click on the Apollo logo on the status bar, stats for the project you're working with are supposed to show, to confirm the config was setup properly and the extension has loaded.
If you're setting up a client project and using a
localSchemaFile
though, the stats will fail to load unless there is a servicename
also provided, which isn't required.This removes the check in the stats loading function that forced a client to have a
client.service.name
even if not using graph manager to load the schema.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.