Swift: Add flag to omit deprecated enum cases #1595
Conversation
|
@kevinmbeaulieu: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Apollo Contributor License Agreement here: https://contribute.apollographql.com/ |
|
Ignore the unrelated failures in the windows 10 one. Can you add some tests for this please? |
|
@designatednerd Added tests for both the enabled & disabled states of the new flag |
| @@ -64,6 +64,9 @@ export default class Generate extends ClientCommand { | |||
| namespace: flags.string({ | |||
| description: "The namespace to emit generated code into." | |||
| }), | |||
| omitDeprecatedEnumCases: flags.boolean({ | |||
| description: "Omit deprecated enum cases from generated code [Swift only]" | |||
There was a problem hiding this comment.
Should this default to false to preserve existing behavior, or would that be overkill?
There was a problem hiding this comment.
Yeah I intended for this to default to false to preserve existing behavior- is that not how it would behave as currently implemented? Looking at the implementation of flags.boolean I saw "specifying a default of false is the same not specifying a default"
There was a problem hiding this comment.
Ah ok (not exactly a typescript expert over here). I think that should work fine, then.
Implement feature request described in apollographql/apollo-ios#840
TODO: