Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tag awareness to client:push #1307

Merged
merged 3 commits into from
Jun 7, 2019

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented May 30, 2019

This PR passes the graphVariant argument to the registerOperations mutation

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.

(https://github.com/mdg-private/monorepo/pull/2338 need to be released to prod before this can be released)

@cheapsteak cheapsteak requested review from trevor-scheer and evans May 31, 2019 15:42
@cheapsteak cheapsteak marked this pull request as ready for review May 31, 2019 15:42
Copy link
Member

@trevor-scheer trevor-scheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@evans evans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!

@cheapsteak cheapsteak force-pushed the chang/ap-465/add-tag-awareness-to-client-push branch from 148160b to 9efeab9 Compare June 6, 2019 21:16
@cheapsteak cheapsteak merged commit 5d72ac1 into master Jun 7, 2019
@cheapsteak cheapsteak deleted the chang/ap-465/add-tag-awareness-to-client-push branch June 7, 2019 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants