Import Foundation in codegen #1248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dfed: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
|
@designatednerd, would you mind taking a look at this when you get the chance? Thanks! |
trevor-scheer
requested review from
designatednerd
and removed request for
jbaxleyiii and
trevor-scheer
|
Would be great to get this forward. Thanks! |
|
@dfed Do you have a bit of time to rebase this, or do you mind if I take over this PR? |
|
Happy to have you take this PR over the finish line @designatednerd! I’m out on vacation this week. |
CHANGELOG.md
Outdated
| @@ -11,7 +11,7 @@ | |||
| - `apollo-codegen-scala` | |||
| - <First `apollo-codegen-scala` related entry goes here> | |||
| - `apollo-codegen-swift` | |||
| - <First `apollo-codegen-swift` related entry goes here> | |||
| - Allow generated code to be compiled without a module umbrella header 1248](https://github.com/apollographql/apollo-tooling/pull/1248) | |||
There was a problem hiding this comment.
fwiw you don't need to put the link here
|
OK cool - ping me when it's ready for another look |
|
🤦♀ Completely misread the earlier comment! Will take this over. |
designatednerd
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi folks! The Swift code-gen today requires that an Objective-C umbrella header be present that has an
import <UIKit/UIKit.h>to compile. You can see this for yourself by running code-gen on any request/response that has aDateas a value or parameter.Datecomes fromFoundation, but there is no import ofFoundation. Instead, the generated code implicitly relies on theUIKitimport from an umbrella header to pull inFoundation.This PR explicitly imports
Foundationin the generated code, which allows consumers of Swift Apollo code-gen to no longer need an umbrella header.TODO:
*Make sure changelog entries note which project(s) has been affected. See older entries for examples on what this looks like.