UI-309 Update output for service:checks plan error #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will also allow us to determine the validation task name before we define the tasks so we don't have to change the task name after we start running. This required changing whitespace on many lines; review this commit with whitespace turned off.
evans
approved these changes
Apr 8, 2019
| @@ -287,10 +287,6 @@ export default class ServiceCheck extends ProjectCommand { | |||
| // Save the output because we're going to use it even if we throw. `runTasks` won't return | |||
| // anything if we throw. | |||
| Object.assign(taskOutput, ctx); | |||
|
|
|||
| task.title = `Validated local schema against tag ${chalk.blue( | |||
There was a problem hiding this comment.
I think this is still valuable for the tense change
We could refactor the functions that generate the messages out and then unit test them. I think we'd be better served spending a few hours to put together e2e tests. I think if we treat this like JavaScript that we can test all the output with relative ease! |
We were calculating it when the task started running before; that was unncessary because we have all the information we need at load time.
For some reason Listr will show a few items more than once. This is not a regression.
justinanastos
force-pushed
the
justin/service-check/current-plan-error
branch
from
90b7ea1 to
ccded7c
Compare
|
@evans I updated the tense change like you requested; that's the only change. |
evans
approved these changes
Apr 9, 2019
I sure do |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes pluralization in the Listr status messages.
All errors thrown will cause Listr to look strange. I was unable to quickly diagnose where the error originates. It exists in prod also so I didn't try too hard to fix it.
TODO: