Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update service:check detailed output order #1168

Merged
merged 3 commits into from
Apr 5, 2019
Merged

Update service:check detailed output order #1168

merged 3 commits into from
Apr 5, 2019

Conversation

justinanastos
Copy link
Contributor

@justinanastos justinanastos commented Apr 5, 2019 •
edited
Loading

Put failures before passes

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@justinanastos justinanastos marked this pull request as ready for review April 5, 2019 18:31
@justinanastos justinanastos requested a review from evans April 5, 2019 18:31
@justinanastos justinanastos force-pushed the justin/service-check/update-pass-fail-order branch from 5453346 to 62abf98 Compare April 5, 2019 19:01
@justinanastos justinanastos merged commit 6e68d47 into master Apr 5, 2019
@justinanastos justinanastos deleted the justin/service-check/update-pass-fail-order branch April 5, 2019 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evans evans evans approved these changes

@jbaxleyiii jbaxleyiii Awaiting requested review from jbaxleyiii

@trevor-scheer trevor-scheer Awaiting requested review from trevor-scheer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@justinanastos @evans