Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add vue as supported language to extract gql #1160

Merged

Conversation

kestred
Copy link
Contributor

@kestred kestred commented Apr 1, 2019

Adds support for vue. Uses the same extracter as typescript/javacript/ ___react.

Just works by adding to list of supported languages.

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@apollo-cla
Copy link

@kestred: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@trevor-scheer
Copy link
Member

@kestred this is great, thanks for adding this! If you can spare the effort, would you mind adding vue support here in the same way? If not, just let me know and I'll take care of it!

Note the file watcher regex a few lines below as well.

@kestred
Copy link
Contributor Author

kestred commented Apr 1, 2019

@trevor-scheer: added

@kestred kestred force-pushed the kstenerson/vue-extract branch from 07b6ad2 to 5074a4b Compare April 1, 2019 23:38
@kestred
Copy link
Contributor Author

kestred commented Apr 1, 2019

Question/Aside: @trevor-scheer - Is it the case that the vscode plugin (that package you had me update) will watch the files and automatically regenerate the types whenever they change?

@trevor-scheer
Copy link
Member

@kestred thanks for the quick turnaround. Merging this now!

Which types do you mean?

I can tell you we currently don't update any typescript types a la codegen.
The change I requested should just ensure that vscode notifies the language server of any changes to files it should be interested in. The language server will then respond accordingly with hooks like this one:

connection.onDidChangeWatchedFiles(params => {

@trevor-scheer trevor-scheer merged commit 1938030 into apollographql:master Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants