Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle subscribe in resolverMap #1047

Merged
merged 4 commits into from
Jul 12, 2019

Conversation

cheapsteak
Copy link
Member

@cheapsteak cheapsteak commented Feb 25, 2019

This PR adds a handler and typing for resolvers for Subscriptions

As Jesse helped find in graphql-tools, resolve and subscribe are not mutually exclusive

I believe this relates to apollographql/apollo-server#2149

TODO:

  • Update CHANGELOG.md* with your change (include reference to issue & this PR)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass

@cheapsteak cheapsteak requested a review from abernix February 27, 2019 23:56
@cheapsteak cheapsteak force-pushed the chang/handle-subscribe-in-resolver-map branch from 8d07e69 to 22c2f82 Compare March 4, 2019 18:39
@sebas5384
Copy link

hi @cheapsteak and @jbaxleyiii !

I'm building an experimental lib as an alternative to @graphql-modules/core called graphql-modules-fn using the buildServiceDefinition() from the apollo-tools like apollo-server does, and I was wondering if there's plans to merge this PR in order to get subscriptions to work with "modules".

thanks!

@trevor-scheer trevor-scheer force-pushed the chang/handle-subscribe-in-resolver-map branch from 22c2f82 to 02fff0e Compare July 12, 2019 18:47
@trevor-scheer trevor-scheer merged commit 0da746e into master Jul 12, 2019
@trevor-scheer trevor-scheer deleted the chang/handle-subscribe-in-resolver-map branch July 12, 2019 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants