Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Critical] Invalid reference to globalTypes.ts #543

Closed
lirbank opened this issue Aug 10, 2018 · 4 comments
Closed

[Critical] Invalid reference to globalTypes.ts #543

lirbank opened this issue Aug 10, 2018 · 4 comments
Labels

Comments

@lirbank
Copy link

lirbank commented Aug 10, 2018

The import of global types in each file looks is missing a file path:

import { SomeInput } from "globalTypes";

It should have a leading ./ for the import to work, eg:

import { SomeInput } from "./globalTypes";

I am using this command:

apollo codegen:generate --queries=\"src/**/*.{ts?(x),graphql}\" --schema=schema.json --clientSchema=clientSchema.graphql --target=typescript --addTypename --tagName=gql --outputFlat src/__generated__/

I really like how you moved all input types to a shared file!

@lirbank
Copy link
Author

lirbank commented Aug 10, 2018

I am using "apollo": "1.7.0",

@shadaj
Copy link
Contributor

shadaj commented Aug 10, 2018

Hi, this is definitely a bug. Investigating now!

@kgtkr
Copy link

kgtkr commented Aug 12, 2018

When will a modified version of this be released?

@lirbank
Copy link
Author

lirbank commented Aug 16, 2018

@shadaj awesome that you found the bug! When do you think you'll be pushing a new release? Anxious to get my hands on all the new features in 1.7.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants