Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfix][Zeta] Fix hazelcast client should overwrite cluster address by system env #7790

Merged
merged 2 commits into from
Oct 8, 2024
Merged

[Hotfix][Zeta] Fix hazelcast client should overwrite cluster address by system env #7790

merged 2 commits into from
Oct 8, 2024

Conversation

liunaijie
Copy link
Member

Purpose of this pull request

fix the client not overwrite cluster address by system env

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the Zeta label Oct 8, 2024
liunaijie
liunaijie commented Oct 8, 2024
View reviewed changes
...l-engine-server/src/test/java/org/apache/seatunnel/engine/server/CoordinatorServiceTest.java
@@ -238,4 +241,28 @@ public void testJobRestoreWhenMasterNodeSwitch() throws InterruptedException {
server2.getCoordinatorService().getJobStatus(jobId)));
instance2.shutdown();
}

@Test
@SetEnvironmentVariable(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no SeaTunnelServerTest, so i add this test into this class.

@liunaijie liunaijie changed the title [fix] hazelcast client overwrite cluster address by system env [Hotfix] hazelcast client overwrite cluster address by system env Oct 8, 2024
@liunaijie liunaijie changed the title [Hotfix] hazelcast client overwrite cluster address by system env [Hotfix][zeta] hazelcast client overwrite cluster address by system env Oct 8, 2024
Hisoka-X
Hisoka-X previously approved these changes Oct 8, 2024
View reviewed changes
dailai
dailai previously approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM If Ci Passed

@liunaijie liunaijie dismissed stale reviews from dailai and Hisoka-X via 2fed748 October 8, 2024 03:18
@Hisoka-X Hisoka-X changed the title [Hotfix][zeta] hazelcast client overwrite cluster address by system env [Hotfix][Zeta] Fix hazelcast client should overwrite cluster address by system env Oct 8, 2024
@hailin0 hailin0 merged commit 62619e8 into apache:dev Oct 8, 2024
8 of 9 checks passed
@liunaijie liunaijie deleted the hotfix/docker_client branch October 9, 2024 01:17
fcb-xiaobo pushed a commit to fcb-xiaobo/seatunnel that referenced this pull request Oct 11, 2024
@liunaijie @fcb-xiaobo
[Hotfix][Zeta] Fix hazelcast client should overwrite cluster address …
40d3e34 
…by system env (apache#7790)
CosmosNi pushed a commit to CosmosNi/seatunnel that referenced this pull request Oct 15, 2024
@liunaijie @CosmosNi
[Hotfix][Zeta] Fix hazelcast client should overwrite cluster address …
8191ff7 
…by system env (apache#7790)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

@dailai dailai dailai left review comments

Assignees
No one assigned
Labels
approved document reviewed Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liunaijie @hailin0 @dailai @Hisoka-X