Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix][Connector-v2] Throw Exception in sql query for JdbcCatalog in table or db exists query #7651

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[Fix][Connector-v2] Throw Exception in sql query for JdbcCatalog in table or db exists query #7651

merged 1 commit into from
Sep 13, 2024

Conversation

dailai
Copy link
Contributor

@dailai dailai commented Sep 13, 2024

Purpose of this pull request

Link pr #7261

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@dailai dailai changed the title [Improve][Connector-v2] Use SQLException instead of Exception in sql query for JdbcCatalog [Improve][Connector-v2] Throw Exception in sql query for JdbcCatalog in table or db exists query Sep 13, 2024
Hisoka-X
Hisoka-X previously approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @dailai

@dailai dailai changed the title [Improve][Connector-v2] Throw Exception in sql query for JdbcCatalog in table or db exists query [Fix][Connector-v2] Throw Exception in sql query for JdbcCatalog in table or db exists query Sep 13, 2024
@hailin0 hailin0 merged commit 70ec59c into apache:dev Sep 13, 2024
6 checks passed
@nianliuu nianliuu mentioned this pull request Sep 14, 2024
Merged
nianliuu referenced this pull request in zilliztech/vts Sep 14, 2024
@dailai @nianliuu
[Fix][Connector-v2] Throw Exception in sql query for JdbcCatalog in t…
f6eb09d 
…able or db exists query (#7651)
@dailai dailai deleted the dev-fix branch November 28, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@hailin0 hailin0 hailin0 approved these changes

Assignees
No one assigned
Labels
approved connectors-v2 jdbc reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dailai @hailin0 @Hisoka-X