[Improve][Zeta] Split the classloader of task group #7580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Hisoka-X
changed the title
|
good job |
Hisoka-X
force-pushed
the
taskgroup-classloader
branch
from
700f2ac to
b041fc8
Compare
3 tasks
4 tasks
Hisoka-X
force-pushed
the
taskgroup-classloader
branch
from
cfd221b to
0be3497
Compare
Hisoka-X
force-pushed
the
taskgroup-classloader
branch
from
a739f54 to
6928753
Compare
3 tasks
hailin0
reviewed
Sep 11, 2024
...e/seatunnel-engine-server/src/test/java/org/apache/seatunnel/engine/server/dag/TaskTest.java
Show resolved
Hide resolved
3 tasks
|
link #7646 |
Hisoka-X
commented
Sep 18, 2024
| @@ -81,7 +80,7 @@ public HiveSourceConfig(ReadonlyConfig readonlyConfig) { | |||
| readonlyConfig | |||
| .getOptional(HdfsSourceConfigOptions.READ_PARTITIONS) | |||
| .ifPresent(this::validatePartitions); | |||
| this.table = HiveTableUtils.getTableInfo(readonlyConfig); | |||
| Table table = HiveTableUtils.getTableInfo(readonlyConfig); | |||
There was a problem hiding this comment.
Avoid conflicts in the logical dag phase of Hive
fcb-xiaobo
pushed a commit
to fcb-xiaobo/seatunnel
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
This PR split classloader of task group. Before this PR, the source and sink use same classloader. This will increase the risk of jar dependency conflicts.
Does this PR introduce any user-facing change?
no
How was this patch tested?
add new test.
Check list
New License Guide
release-note.