Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature][Core] Add event notify for all connector #7501

Merged
merged 6 commits into from
Aug 28, 2024
Merged

[Feature][Core] Add event notify for all connector #7501

merged 6 commits into from
Aug 28, 2024

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

@Hisoka-X

1. Source-related Classes

Class Name Method Introduced Event
SourceFlowLifeCycle open ReaderOpenEvent
SourceFlowLifeCycle close ReaderCloseEvent
ParallelSource open ReaderOpenEvent
ParallelSource close ReaderCloseEvent
CoordinatedSource open ReaderOpenEvent
CoordinatedSource close ReaderCloseEvent
FlinkSourceReader start ReaderOpenEvent
FlinkSourceReader close ReaderCloseEvent

2. Enumerator-related Classes

Class Name Method Introduced Event
SourceSplitEnumeratorTask stateProcess EnumeratorOpenEvent
SourceSplitEnumeratorTask close EnumeratorCloseEvent
CoordinatedSource open EnumeratorOpenEvent
CoordinatedSource close EnumeratorCloseEvent
ParallelSource open EnumeratorOpenEvent
ParallelSource close EnumeratorCloseEvent
FlinkSourceEnumerator start EnumeratorOpenEvent
FlinkSourceEnumerator close EnumeratorCloseEvent

3. Sink-related Classes

Class Name Method Introduced Event
SinkFlowLifeCycle close WriterCloseEvent
MultiTableSinkWriter close WriterCloseEvent
FlinkSinkWriter close WriterCloseEvent
SparkDataWriter commit WriterCloseEvent
SeaTunnelSparkDataWriter commit WriterCloseEvent

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@zhangshenghang zhangshenghang changed the title [Feature][Zeata] add event notify [Feature][Zeta] add event notify Aug 27, 2024
Hisoka-X
Hisoka-X reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zhangshenghang ! Overall LGTM. I left some minior problem.

...nel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java Outdated Show resolved Hide resolved
...nel-api/src/main/java/org/apache/seatunnel/api/sink/multitablesink/MultiTableSinkWriter.java Show resolved Hide resolved
...ine-server/src/main/java/org/apache/seatunnel/engine/server/task/flow/SinkFlowLifeCycle.java Outdated Show resolved Hide resolved
@Hisoka-X Hisoka-X changed the title [Feature][Zeta] add event notify [Feature][Core] Add event notify for all connector Aug 27, 2024
Hisoka-X
Hisoka-X approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @zhangshenghang

wuchunfu
wuchunfu approved these changes Aug 28, 2024
View reviewed changes
Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @zhangshenghang

@wuchunfu wuchunfu merged commit d71337b into apache:dev Aug 28, 2024
5 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
@zhangshenghang @hawk9821
[Feature][Core] Add event notify for all connector (apache#7501)
4c6d6a6 
* [feature]add event notify

* [feature]add event notify

* [fixbug]fix some problem

* [feature]fix some problem

* [feature]fix some problem
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
@zhangshenghang @hawk9821
[Feature][Core] Add event notify for all connector (apache#7501)
3679a81 
* [feature]add event notify

* [feature]add event notify

* [fixbug]fix some problem

* [feature]fix some problem

* [feature]fix some problem
@zhangshenghang zhangshenghang deleted the feature-add-event-notify branch September 6, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hisoka-X Hisoka-X Hisoka-X approved these changes

@wuchunfu wuchunfu wuchunfu approved these changes

Assignees
No one assigned
Labels
api approved connectors-v2 e2e flink reviewed Spark Zeta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Zeta] Unify the triggering logic of job status related events
3 participants
@zhangshenghang @wuchunfu @Hisoka-X