Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Connector-V2] Fix jdbc query sql can not get table path #7484

Merged
merged 8 commits into from
Aug 28, 2024

Conversation

corgy-w
Copy link
Contributor

@corgy-w corgy-w commented Aug 24, 2024

Purpose of this pull request

issue : #7480

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

@github-actions github-actions bot added the e2e label Aug 26, 2024
@corgy-w corgy-w force-pushed the fix-part-jdbc-multi-metrics branch from a9e4d95 to b2b4ff3 Compare August 27, 2024 07:20
@Hisoka-X Hisoka-X changed the title [Fix][Connector-V2] fix part jdbc-multi-metrics bug [Fix][Connector-V2] Fix jdbc query sql can not get table path Aug 27, 2024
Hisoka-X
Hisoka-X previously approved these changes Aug 28, 2024
@wuchunfu
Copy link
Member

@corgy-w Please resolve the CI issue, thanks

@Hisoka-X
Copy link
Member

@@ -43,7 +44,7 @@ public class JdbcHiveIT extends AbstractJdbcIT {

private static final String HIVE_DATABASE = "default";

private static final String HIVE_SOURCE = "e2e_table_source";
private static final String HIVE_SOURCE = "hive_e2e_source_table";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why change this?

Copy link
Contributor Author

@corgy-w corgy-w Aug 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

In this case, the create statement is hive_e2e_source_table

Hisoka-X
Hisoka-X previously approved these changes Aug 28, 2024
Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @corgy-w

# Conflicts:
#	docs/en/connector-v2/source/PostgreSQL.md
@wuchunfu wuchunfu merged commit 8e0ca8f into apache:dev Aug 28, 2024
8 checks passed
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
…#7484)

* [Fix][Connector-V2] fix jdbc-multi-metrics bug

* [Fix][Connector-V2] fix part jdbc-multi-metrics bug

* [Fix][Connector-V2] optimized code

* [Fix][Connector-V2] update test case

* [Fix][Connector-V2] update

* [Fix][Connector-V2] update

* [Fix][Connector-V2] update

---------

Co-authored-by: Jia Fan <[email protected]>
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
…#7484)

* [Fix][Connector-V2] fix jdbc-multi-metrics bug

* [Fix][Connector-V2] fix part jdbc-multi-metrics bug

* [Fix][Connector-V2] optimized code

* [Fix][Connector-V2] update test case

* [Fix][Connector-V2] update

* [Fix][Connector-V2] update

* [Fix][Connector-V2] update

---------

Co-authored-by: Jia Fan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants