Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature][Connector-V2]Support tidb cdc connector source #7477

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

sunxiaojian
Copy link
Contributor

@sunxiaojian sunxiaojian commented Aug 23, 2024

Purpose of this pull request

closed #7199

Does this PR introduce any user-facing change?

How was this patch tested?

Check list

.idea/vcs.xml Outdated
@@ -1,24 +1,5 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why update this file

@@ -0,0 +1,129 @@
# PostgreSQL CDC
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add zh docs

@@ -140,7 +142,9 @@ public Column convert(BasicTypeDefine typeDefine) {
case MYSQL_NULL:
builder.dataType(BasicType.VOID_TYPE);
break;

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert

value = {},
type = {EngineType.SPARK},
disabledReason = "Currently SPARK do not support cdc")
public class TiDBCDCIT extends TiDBTestBase implements TestResource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 4 times, most recently from 8267c66 to 4bc7d20 Compare August 24, 2024 13:11

## 主要功能

- [x] [批处理](../../concept/connector-v2-features.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

support batch mode?

@hailin0
Copy link
Member

hailin0 commented Aug 24, 2024

cc @dailai

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 4 times, most recently from 90ba526 to bbae550 Compare August 26, 2024 07:57
@dailai
Copy link
Contributor

dailai commented Aug 28, 2024

Please resolve the confilict and retrigger the ci.

@dailai
Copy link
Contributor

dailai commented Aug 30, 2024

Please fix the ci.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 2 times, most recently from 3e63cac to 090fcdf Compare September 2, 2024 06:07
value = {},
type = {EngineType.SPARK},
disabledReason = "Currently SPARK do not support cdc")
public class TiDBCDCIT extends TiDBTestBase implements TestResource {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sunxiaojian. Please add the e2e case that restore from savepoint.

@sunxiaojian sunxiaojian force-pushed the support-tidb-cdc branch 3 times, most recently from b562f81 to c4d1fde Compare September 5, 2024 03:53
Copy link
Contributor

@dailai dailai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hailin0 hailin0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hisoka-X Hisoka-X merged commit 87ec786 into apache:dev Sep 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][CDC] Support tidb cdc connector source
4 participants