Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] Improve some connectors prepare check error message #7465

Merged

Conversation

zhangshenghang
Copy link
Member

Purpose of this pull request

image

My influxDB version is 1.3.7. When using SeaTunnel, an error message is displayed: Get column index of query result exception. There is no error message about incorrect version. The exception of the supported version range should be returned to the customer to facilitate troubleshooting.

How was this patch tested?

Runs locally and on servers

Check list

@Hisoka-X
Copy link
Member

Before this PR, can we get the version error message from cause by block of InfluxdbConnectorException? I checked the code, the answer is yes if I don't miss anything.

@Hisoka-X
Copy link
Member

@Hisoka-X Hisoka-X changed the title [Improve] influxdb exception print [Improve] Improve some connectors prepare check error message Aug 23, 2024
@github-actions github-actions bot removed the influxdb label Aug 23, 2024
@zhangshenghang
Copy link
Member Author

Could you help to fix

and

too?

Modified. Cassandra is modified to

throw new CassandraConnectorException(
SeaTunnelAPIErrorCode.CONFIG_VALIDATION_FAILED,
String.format(
"PluginName: %s, PluginType: %s, Message: %s %s",
getPluginName(),
PluginType.SINK,
checkResult.getMsg(),
ExceptionUtils.getMessage(e))); 

because checkResult is an externally spliced ​​object.

Copy link
Member

@Hisoka-X Hisoka-X left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if ci passes. Thanks @zhangshenghang

Copy link
Member

@wuchunfu wuchunfu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wuchunfu wuchunfu merged commit 6930a25 into apache:dev Aug 23, 2024
5 checks passed
@zhangshenghang zhangshenghang deleted the improve-influxdb-exception-log-print branch August 23, 2024 05:11
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
…#7465)

* [improve]influxdb exception log print

* [fixbug]fix some problem

* [improve]improve print

* [improve]improve cassandra and clickhou exception print

* [improve]improve cassandra exception print
hawk9821 pushed a commit to hawk9821/seatunnel that referenced this pull request Aug 29, 2024
…#7465)

* [improve]influxdb exception log print

* [fixbug]fix some problem

* [improve]improve print

* [improve]improve cassandra and clickhou exception print

* [improve]improve cassandra exception print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants