-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature][Zeta] Added other metrics info of multi-table #7338
Conversation
cc @hawk9821 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure the http api return new metrics too. And add test case in
Line 99 in 16950a6
.body("metrics.SinkWriteCount", equalTo("50")) |
get |
...or-seatunnel-e2e-base/src/test/java/org/apache/seatunnel/engine/e2e/MultiTableMetricsIT.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/apache/seatunnel/engine/server/metrics/TaskMetricsCalcContext.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/apache/seatunnel/engine/server/metrics/TaskMetricsCalcContext.java
Outdated
Show resolved
Hide resolved
...-server/src/main/java/org/apache/seatunnel/engine/server/metrics/TaskMetricsCalcContext.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except one minior problem.
...-server/src/main/java/org/apache/seatunnel/engine/server/metrics/TaskMetricsCalcContext.java
Outdated
Show resolved
Hide resolved
import java.util.stream.StreamSupport; | ||
|
||
import static com.hazelcast.internal.ascii.rest.HttpStatusCode.SC_500; | ||
import static org.apache.seatunnel.api.common.metrics.MetricNames.SINK_WRITE_BYTES; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @liugddx better take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.Wait for CI to pass
Purpose of this pull request
issue : #7331
Does this PR introduce any user-facing change?
How was this patch tested?
Check list
New License Guide
release-note
.